-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(emails): broadcast v0.5 added #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR adds a new email broadcast template for the v0.5 release announcement and fixes the deployment version badge in log details to use the EMCN Badge component instead of hardcoded styles. Key changes:
Issues found:
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant LogDetailsUI
participant BadgeComponent
participant EmailTemplate
participant Assets
Note over User,Assets: Bug Fix: Log Details Badge
User->>LogDetailsUI: View log details
LogDetailsUI->>BadgeComponent: Render deployment version
BadgeComponent-->>LogDetailsUI: Display Badge(variant='green', size='md')
LogDetailsUI-->>User: Show styled version badge
Note over User,Assets: New Feature: Email Broadcast v0.5
User->>EmailTemplate: Receive email broadcast
EmailTemplate->>Assets: Load logo.svg
Assets-->>EmailTemplate: ✓ Logo loaded
EmailTemplate->>Assets: Load copilot.gif
Assets-->>EmailTemplate: ✓ Copilot GIF loaded
EmailTemplate->>Assets: Load dashboard.jpeg
Assets-->>EmailTemplate: ✓ Dashboard image loaded
EmailTemplate->>Assets: Load mcp.png
Assets-->>EmailTemplate: ✗ Missing image
EmailTemplate-->>User: Render email (with broken MCP image)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| <table cellspacing="0" cellpadding="0" border="0" role="presentation"> | ||
| <tr> | ||
| <td align="center" style="padding-bottom:16px;"> | ||
| <img src="https://sim.ai/email/broadcast/v0.5/mcp.png" width="48" height="48" alt="MCP" style="display:block;" border="0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: missing mcp.png image at /apps/sim/public/email/broadcast/v0.5/mcp.png - this will break the email template
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/emails/broadcasts/v0.5.html
Line: 94:94
Comment:
**logic:** missing `mcp.png` image at `/apps/sim/public/email/broadcast/v0.5/mcp.png` - this will break the email template
How can I resolve this? If you propose a fix, please make it concise.aac18f0 to
0c3af3d
Compare
* fix(google): wrap primitive tool responses for Gemini API compatibility (#2900) * fix(canonical): copilot path + update parent (#2901) * fix(rss): add top-level title, link, pubDate fields to RSS trigger output (#2902) * fix(rss): add top-level title, link, pubDate fields to RSS trigger output * fix(imap): add top-level fields to IMAP trigger output * improvement(browseruse): add profile id param (#2903) * improvement(browseruse): add profile id param * make request a stub since we have directExec * improvement(executor): upgraded abort controller to handle aborts for loops and parallels (#2880) * improvement(executor): upgraded abort controller to handle aborts for loops and parallels * comments * improvement(files): update execution for passing base64 strings (#2906) * progress * improvement(execution): update execution for passing base64 strings * fix types * cleanup comments * path security vuln * reject promise correctly * fix redirect case * remove proxy routes * fix tests * use ipaddr * feat(tools): added textract, added v2 for mistral, updated tag dropdown (#2904) * feat(tools): added textract * cleanup * ack pr comments * reorder * removed upload for textract async version * fix additional fields dropdown in editor, update parser to leave validation to be done on the server * added mistral v2, files v2, and finalized textract * updated the rest of the old file patterns, updated mistral outputs for v2 * updated tag dropdown to parse non-operation fields as well * updated extension finder * cleanup * added description for inputs to workflow * use helper for internal route check * fix tag dropdown merge conflict change * remove duplicate code --------- Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai> * fix(ui): change add inputs button to match output selector (#2907) * fix(canvas): removed invite to workspace from canvas popover (#2908) * fix(canvas): removed invite to workspace * removed unused props * fix(copilot): legacy tool display names (#2911) * fix(a2a): canonical merge (#2912) * fix canonical merge * fix empty array case * fix(change-detection): copilot diffs have extra field (#2913) * improvement(logs): improved logs ui bugs, added subflow disable UI (#2910) * improvement(logs): improved logs ui bugs, added subflow disable UI * added duplicate to action bar for subflows * feat(broadcast): email v0.5 (#2905) --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Summary
Added email broadcast.
Fixed logs details.
Type of Change
Testing
Solo.
Checklist